Skip to content

chore(deps): update puppeteer to v25#219

Open
renovate[bot] wants to merge 1 commit into
mainfrom
renovate/major-puppeteer
Open

chore(deps): update puppeteer to v25#219
renovate[bot] wants to merge 1 commit into
mainfrom
renovate/major-puppeteer

Conversation

@renovate

@renovate renovate Bot commented May 17, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
puppeteer (source) ^24.43.1^25.1.0 age confidence

Release Notes

puppeteer/puppeteer (puppeteer)

v25.1.0

Compare Source

🎉 Features
🛠️ Fixes
🏗️ Refactor
Dependencies
  • The following workspace dependencies were updated
📄 Documentation

v25.0.4

Compare Source

♻️ Chores
  • puppeteer: Synchronize puppeteer versions
Dependencies
  • The following workspace dependencies were updated
    • dependencies
      • puppeteer-core bumped from 25.0.3 to 25.0.4
🛠️ Fixes

v25.0.3

Compare Source

♻️ Chores
  • puppeteer: Synchronize puppeteer versions
Dependencies
  • The following workspace dependencies were updated
    • dependencies
      • puppeteer-core bumped from 25.0.3 to 25.0.4
🛠️ Fixes

v25.0.2

Compare Source

♻️ Chores
  • puppeteer: Synchronize puppeteer versions
Dependencies
  • The following workspace dependencies were updated
🛠️ Fixes

Configuration

📅 Schedule: (in timezone Asia/Shanghai)

  • Branch creation
    • Between 12:00 AM and 03:59 AM, on day 1 and 15 of the month (* 0-3 1,15 * *)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate Bot force-pushed the renovate/major-puppeteer branch 4 times, most recently from 71d587e to e8901d0 Compare May 19, 2026 16:02
@renovate renovate Bot force-pushed the renovate/major-puppeteer branch 3 times, most recently from 83de691 to 6fff65f Compare May 28, 2026 16:15
@renovate renovate Bot force-pushed the renovate/major-puppeteer branch from 6fff65f to 433ba6a Compare June 3, 2026 03:01
@renovate renovate Bot changed the title chore(deps): update dependency puppeteer to v25 chore(deps): update puppeteer to v25 Jun 3, 2026
@renovate renovate Bot force-pushed the renovate/major-puppeteer branch from 433ba6a to 65d4145 Compare June 13, 2026 19:52
@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This pull request updates the puppeteer development dependency in package.json from version ^24.43.1 to ^25.1.0. The change is a straightforward minor version bump with a single line modification, affecting only the dependency declaration in the package configuration file.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately describes the main change: updating the puppeteer dependency to v25.
Description check ✅ Passed The description is directly related to the changeset, providing detailed release notes and context for the puppeteer v25 update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch renovate/major-puppeteer

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@package.json`:
- Line 80: The puppeteer bump in package.json (the "puppeteer" dependency)
conflicts with the declared engines.node range (engines.node) because
puppeteer@25 requires node >=22.12.0 and our test/install script
(scripts/install-puppeteer-browser.mjs) imports Puppeteer at install time; fix
by either 1) pinning "puppeteer" in package.json to a version that still
supports Node 20 (choose a 24.x release known to support Node 20) so the current
engines.node range remains valid, or 2) raising package.json's engines.node to
">=22.12.0" (and update docs/automation and any developer notes and ensure
.github/workflows/test.yml / CI Node versions align) so the declared node
support matches puppeteer@25; apply only one of these fixes and update
pnpm-lock.yaml by reinstalling dependencies.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a1e518c1-b152-498f-a2f1-51d297fbe8ae

📥 Commits

Reviewing files that changed from the base of the PR and between 4e34025 and 65d4145.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • package.json

Comment thread package.json
"p-retry": "^7.1.1",
"prettier": "3.8.3",
"puppeteer": "^24.43.1",
"puppeteer": "^25.1.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== Root engine declaration =="
jq -r '.engines.node' package.json

echo
echo "== Puppeteer engine requirements from lockfile =="
rg -n -A2 -B1 'puppeteer(@|-)25\.1\.0|engines:\s*\{node:\s*' pnpm-lock.yaml

echo
echo "== Test scripts that require Puppeteer =="
jq -r '.scripts | to_entries[] | select(.key|test("test")) | "\(.key): \(.value)"' package.json

echo
echo "== CI/workflow node-version references (if present) =="
fd -HI '.*\.(yml|yaml)$' .github/workflows 2>/dev/null \
  | xargs -r rg -n -C2 'setup-node|node-version|matrix'

Repository: rstackjs/rspack-dev-server

Length of output: 36815


🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== package.json (around engines + dependency section) =="
nl -ba package.json | sed -n '60,120p'

echo
echo "== scripts/install-puppeteer-browser.mjs (imports/usage) =="
if [ -f scripts/install-puppeteer-browser.mjs ]; then
  nl -ba scripts/install-puppeteer-browser.mjs | sed -n '1,200p'
else
  echo "Missing scripts/install-puppeteer-browser.mjs"
fi

echo
echo "== CI workflows (node-version references) =="
fd -HI '.*\.(yml|yaml)$' .github/workflows \
  | xargs -r rg -n -C1 'setup-node|node-version|matrix'

echo
echo "== engine-strict config (npm/pnpm/yarn) =="
ls -la | rg -n '\.npmrc|\.pnpmrc|\.yarnrc|packageManager\.yml' || true
for f in .npmrc .pnpmrc .yarnrc .yarnrc.yml packageManager.yml; do
  if [ -f "$f" ]; then
    echo "--- $f ---"
    cat -n "$f"
  fi
done

Repository: rstackjs/rspack-dev-server

Length of output: 188


🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== package.json (around engines + dependency section) =="
sed -n '1,140p' package.json | cat -n

echo
echo "== scripts/install-puppeteer-browser.mjs (imports/usage) =="
if [ -f scripts/install-puppeteer-browser.mjs ]; then
  sed -n '1,220p' scripts/install-puppeteer-browser.mjs | cat -n
else
  echo "Missing scripts/install-puppeteer-browser.mjs"
fi

echo
echo "== CI workflows (node-version references) =="
fd -HI '.*\.(yml|yaml)$' .github/workflows \
  | xargs -r rg -n -C1 'setup-node|node-version|matrix' || true

echo
echo "== engine-strict config (.npmrc/.pnpmrc/.yarnrc) =="
for f in .npmrc .pnpmrc .yarnrc .yarnrc.yml packageManager.yml; do
  if [ -f "$f" ]; then
    echo "--- $f ---"
    sed -n '1,120p' "$f" | cat -n
  fi
done

Repository: rstackjs/rspack-dev-server

Length of output: 8497


🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== Search for engine-strict / engines enforcement =="
rg -n --hidden --glob '!.git' 'engine-strict|engine strict|enginesStrict|pnpm.*engine|npm.*engine' .

echo
echo "== Check if README/docs mention supported Node versions =="
rg -n --hidden --glob '!.git' 'Node (>=|js )?(20|22)|node-version|engines\.node|supported Node' README* docs* . || true

Repository: rstackjs/rspack-dev-server

Length of output: 123


🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== Search for engine-strict enforcement knobs =="
rg -n --hidden --glob '!.git' 'engine-strict|engineStrict|ENGINES_STRICT' .

echo
echo "== Search for pnpm config section mentioning engines =="
rg -n --hidden --glob '!.git' 'engines' .npmrc .pnpmrc pnpm-workspace.yaml package.json 2>/dev/null || true

Repository: rstackjs/rspack-dev-server

Length of output: 119


Fix Puppeteer/Node engine contract mismatch

package.json declares Node support ^20.19.0 || >=22.12.0 (line 100), but bumping puppeteer to ^25.1.0 (line 80) pulls puppeteer@25.1.0 / puppeteer-core@25.1.0 which require node >=22.12.0 (pnpm-lock.yaml). This repo’s pnpm test runs test:installscripts/install-puppeteer-browser.mjs, which imports Puppeteer and installs Chrome, so Node 20 contributors are likely to hit install/runtime failures. CI is already pinned to Node 24.16.0 in .github/workflows/test.yml, so the mismatch is primarily for local Node 20 runs.

Remediation options:

  • Pin Puppeteer to a version that supports Node 20 while keeping the current engines.node, or
  • Raise package.json#engines.node to >=22.12.0 (and align any docs/automation) so the declared support matches test/runtime tooling.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@package.json` at line 80, The puppeteer bump in package.json (the "puppeteer"
dependency) conflicts with the declared engines.node range (engines.node)
because puppeteer@25 requires node >=22.12.0 and our test/install script
(scripts/install-puppeteer-browser.mjs) imports Puppeteer at install time; fix
by either 1) pinning "puppeteer" in package.json to a version that still
supports Node 20 (choose a 24.x release known to support Node 20) so the current
engines.node range remains valid, or 2) raising package.json's engines.node to
">=22.12.0" (and update docs/automation and any developer notes and ensure
.github/workflows/test.yml / CI Node versions align) so the declared node
support matches puppeteer@25; apply only one of these fixes and update
pnpm-lock.yaml by reinstalling dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants